Skip to content

Reduce copy and paste within MergeStorage #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 11, 2023
Merged

Reduce copy and paste within MergeStorage #275

merged 1 commit into from
Jul 11, 2023

Conversation

fabianfett
Copy link
Member

In MergeStorage we have the same code three times. Let's refactor it to only keep one copy of it.

FranzBusch
FranzBusch approved these changes Jul 11, 2023
View reviewed changes
Copy link
Member

@FranzBusch FranzBusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@FranzBusch FranzBusch merged commit 07a0c1e into apple:main Jul 11, 2023
@fabianfett fabianfett deleted the ff-reduce-copy-and-paste branch July 11, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FranzBusch FranzBusch FranzBusch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fabianfett @FranzBusch