Skip to content

Conversation

FranzBusch
Copy link
Member

Motivation

@unchecked Sendable is a great way to make a type Sendable while it is not really Sendable this is rarely useful and we should rather use conditional @unchecked Sendable annotations such as the one on ManagedCriticalState

Modification

This PR removes all @unchecked Sendable in the main algorithm target except the one on Merge since we are doing manual locking there.

Result

No more @unchecked Sendable usage.

# Motivation
`@unchecked Sendable` is a great way to make a type `Sendable` while it is not really `Sendable` this is rarely useful and we should rather use conditional `@unchecked Sendable` annotations such as the one on `ManagedCriticalState`

# Modification
This PR removes all `@unchecked Sendable` in the main algorithm target except the one on `Merge` since we are doing manual locking there.

# Result
No more `@unchecked Sendable` usage.
@FranzBusch FranzBusch added the v1.0 Work leading up first API stable version label Sep 21, 2023
@phausler phausler merged commit f565569 into apple:main Sep 21, 2023
@FranzBusch FranzBusch deleted the fb-unchecked-Sendable branch September 21, 2023 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v1.0 Work leading up first API stable version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants