Fix AsyncBufferSequence leaking base sequence #352
+41
−15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
AsyncBufferSequence
will leak the base sequence if iteration concludes withoutnext()
being cancelled. This is because the internal task retainsUnboundedBufferStorage
/BoundedBufferStorage
causing a reference cycle. This is fixed by adopting anInternalClass
inside the iterator which calls aniteratorDeinitialized()
function on the storage, as done by other sequences in this package such as combine latest and merge.The following code illustrates the issue: the assert fails meaning the channel has leaked.