Cryptographic Message Syntax ASN.1 de/serialisation #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnadoba
commented
Feb 2, 2023
dnadoba
commented
Feb 2, 2023
… type does not conform to `DERImplicitlyTaggable`
Lukasa
reviewed
Feb 2, 2023
|
|
||
| // TODO: support multiple signer infos. For this we need to validate that the binary representation of each element is lexicographically sorted. | ||
| guard signerInfos.count <= 1 else { | ||
| throw Error.multipleDigestAlgorithmsAreNotSupportedYet |
There was a problem hiding this comment.
Presumably this was meant to be the signer infos error.
There was a problem hiding this comment.
Good catch! Thanks. Fixed in c33a826
| enum CMSSignerIdentifier { | ||
| enum CMSSignerIdentifier: DERParseable, DERSerializable, Hashable { | ||
|
|
||
| private static let subjectKeyIdentifierIdentifier = ASN1Identifier(tagWithNumber: 0, tagClass: .contextSpecific) |
There was a problem hiding this comment.
Maybe call this skiIdentifier, repeating the word identifier feels weird here.
There was a problem hiding this comment.
Agree, changed in c33a826
Lukasa
approved these changes
Feb 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.