Custom certificate store #256
Open
+409
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This new protocol allows one to customize the logic for matching an issuer to the subject certificate authority.
This change would allow for certificates to be dynamically looked up in a database.
Lukasa
reviewed
Jun 13, 2025
|
|
||
| @available(macOS 10.15, iOS 13, watchOS 6, tvOS 13, macCatalyst 13, visionOS 1.0, *) | ||
| extension CertificateStore.Resolved { | ||
| @usableFromInline |
There was a problem hiding this comment.
These may as well also become @inlinable.
There was a problem hiding this comment.
Good call. I've updated as such.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support for implementing a
CustomCertificateStorein a backwards compatible way with minimal impact to performance. A custom certificate store can be implemented, and then the newCertificateStore(custom:)constructor can be used so that the custom certificate store can be used interchangeably with a "normal" certificate store.Additionally, a test case verifies that this new protocol will work for our use case. More specifically, the use case we have is for normalization of distinguished names so that an exact match of distinguished names is no longer required. For example, if
printableStringshould be used interchangeably with autf8String.This pull request has two commits:
CustomCertificateStoreasynclookup of certificiates.The second change is not required for our use-case, however I would expect that there may be a future use-case that requires looking up certificates in a database, and supporting an
asyncprotocol would be valuable. Also, theverify()method is already async, so supporting anasynclookup does not disrupt any existing public APIs.