Skip to content
This repository was archived by the owner on Mar 28, 2020. It is now read-only.

[Swift+WASM] Adopt SwiftABIInfo for WebAssembly. #235

Closed
wants to merge 1 commit into from
Closed

[Swift+WASM] Adopt SwiftABIInfo for WebAssembly. #235

wants to merge 1 commit into from

Conversation

ddunbar
Copy link
Member

@ddunbar ddunbar commented Nov 20, 2018

No description provided.

@ddunbar
Copy link
Member Author

ddunbar commented Nov 20, 2018

This is part of super early days exploration of what is required for WASM support. Given the open-ended nature of it, and the instability of WASM itself and the LLVM implementation, I haven't really tried to make this a very principled implementation but rather am trying to work through the minimal changes needed to start getting end-to-end wasm objects out of Swift.

LMK if you think this is a reasonable approach & way to land...

@ddunbar
Copy link
Member Author

ddunbar commented Nov 20, 2018

@swift-ci please smoke test

DougGregor
DougGregor approved these changes Nov 20, 2018
View reviewed changes
Copy link
Member

@DougGregor DougGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This approach seems reasonable to me. I expect there will be a lot of experimentation needed to figure out how best to do this

@ddunbar
Copy link
Member Author

ddunbar commented Nov 20, 2018

@DougGregor do we have smoke testing for Clang changes? Is merging into stable the right thing to do?

@ddunbar
Copy link
Member Author

ddunbar commented Nov 20, 2018

Hmm from looking at other PRs I guess I’m supposed to go to upstream-with-swift maybe?

@ddunbar ddunbar changed the base branch from stable to upstream-with-swift November 20, 2018 22:10
@ddunbar ddunbar changed the base branch from upstream-with-swift to stable November 20, 2018 22:11
@ddunbar ddunbar force-pushed the swasm-adopt-swiftabiinfo-for-wasm branch from 1cf0412 to 33a8bc9 Compare November 20, 2018 22:12
@ddunbar ddunbar changed the base branch from stable to upstream-with-swift November 20, 2018 22:13
@ddunbar
Copy link
Member Author

ddunbar commented Nov 20, 2018

Switch to be a PR against upstream-with-swift

@ddunbar
Copy link
Member Author

ddunbar commented Nov 20, 2018

@swift-ci please test

@ddunbar
Copy link
Member Author

ddunbar commented Nov 20, 2018

@swift-ci please test linux platform

@ddunbar
Copy link
Member Author

ddunbar commented Nov 20, 2018

@swift-ci please test MacOSX platform

@ddunbar ddunbar mentioned this pull request Nov 20, 2018
Closed
1 task
@patcheng patcheng mentioned this pull request Jan 2, 2019
Closed
@ddunbar
Copy link
Member Author

ddunbar commented Jan 3, 2019

Closing this, this code has been upstreamed to Clang (llvm-mirror/clang@c72bf46)

@ddunbar ddunbar closed this Jan 3, 2019
@ddunbar ddunbar deleted the swasm-adopt-swiftabiinfo-for-wasm branch January 3, 2019 23:31
@ddunbar ddunbar mentioned this pull request Nov 20, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DougGregor DougGregor DougGregor approved these changes

@rjmccall rjmccall Awaiting requested review from rjmccall

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ddunbar @DougGregor