Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.0][OrderedSet] Make _checkInvariants public and call it in more operations #106

Merged
merged 3 commits into from
Sep 9, 2021

Conversation

lorentey
Copy link
Member

@lorentey lorentey commented Sep 7, 2021

It seems useful to be able to manually call _checkInvariants while debugging a package issue. This is public as in public, not public as in Public API -- it's underscored.

This also adds more _checkInvariants invocations in functions that return newly created ordered sets.

Checklist

  • I've read the Contribution Guidelines
  • My contributions are licensed under the Swift license.
  • I've followed the coding style of the rest of the project.
  • I've added tests covering all new code paths my change adds to the project (if appropriate).
  • I've added benchmarks covering new functionality (if appropriate).
  • I've verified that my change does not break any existing tests or introduce unexplained benchmark regressions.
  • I've updated the documentation if necessary.

@lorentey lorentey mentioned this pull request Sep 7, 2021
7 tasks
@lorentey
Copy link
Member Author

lorentey commented Sep 8, 2021

@swift-ci test

@lorentey
Copy link
Member Author

lorentey commented Sep 8, 2021

(The idea here is that this may allow us to find the culprit in #104 quicker, if it proves to be a bug in the package.)

Copy link
Contributor

@glessard glessard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks quite reasonable.

@lorentey lorentey force-pushed the check-please branch 2 times, most recently from 7d04725 to 7d18128 Compare September 9, 2021 04:10
@lorentey
Copy link
Member Author

lorentey commented Sep 9, 2021

@swift-ci test

It seems useful to be able to manually call `_checkInvariants` while debugging a package issue. This is public as in `public`, not public as in Public API -- it's underscored.
@lorentey
Copy link
Member Author

lorentey commented Sep 9, 2021

@swift-ci test

@lorentey lorentey merged commit 95fa069 into apple:release/1.0 Sep 9, 2021
@lorentey lorentey deleted the check-please branch September 9, 2021 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants