Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TreeSet.md #296

Closed
wants to merge 1 commit into from
Closed

Update TreeSet.md #296

wants to merge 1 commit into from

Conversation

hassila
Copy link
Contributor

@hassila hassila commented Jun 20, 2023

Fix typo

Replace this paragraph with a description of your changes and rationale. Provide links to an existing issue or external references/discussions, if appropriate.

Checklist

  • [ x] I've read the Contribution Guidelines
  • [ x] My contributions are licensed under the Swift license.
  • [ x] I've followed the coding style of the rest of the project.
  • I've added tests covering all new code paths my change adds to the project (if appropriate).
  • I've added benchmarks covering new functionality (if appropriate).
  • I've verified that my change does not break any existing tests or introduce unexplained benchmark regressions.
  • [x ] I've updated the documentation if necessary.

@hassila hassila requested a review from lorentey as a code owner June 20, 2023 18:50
Copy link
Member

@lorentey lorentey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! 👍

I think this should better go on release/1.1, not main; would you be willing to rebase this PR on that branch? (Otherwise this change would only show up in the feature release following 1.1.)

@hassila
Copy link
Contributor Author

hassila commented Jun 21, 2023

Sure, I opened #297 for that, will close this one.

@hassila hassila closed this Jun 21, 2023
@hassila hassila mentioned this pull request Jun 21, 2023
7 tasks
@MaxDesiatov
Copy link
Member

Does cherry-picking from release/1.1 to main happen after the fact? If not, should this be reopened and still considered for main?

@lorentey
Copy link
Member

I'm manually propagating changes along the release/1.0release/1.1main chain, so things landing for 1.1 will (eventually) also appear on main -- there is no need to file separate PRs for each branch.

This should probably be explained in the README; I'll make a note to update it.

@hassila hassila deleted the patch-1 branch June 22, 2023 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants