-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[test] TreeDictionary.Keys: Remove stray print that’s flooding test output #370
[test] TreeDictionary.Keys: Remove stray print that’s flooding test output #370
Conversation
@swift-ci test |
@lorentey Ahh… this is a good fix! Sorry about that one. Would these fixes happen enough that some kind of linter that automatically flags a diff with |
@vanvoorden Oh I didn't even remember this was a recent addition. This is not a big deal! And it's pretty easy to catch by looking through CI output -- which is how this one came to light. It can be legitimate for tests to print, and I don't think we want to develop a linter for this. We can simply catch these as they happen. |
Huh, this isn't ideal:
This looks like a recent compiler regression. I'll look into it tomorrow. |
@swift-ci test |
The
test_isEqual_exhaustive
test includes a stray print statement that is flooding test output with a myriad lines of useless data.Checklist