Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 'final' keyword to class #403

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Conversation

quokkaKyu
Copy link
Contributor

Hello, How about adding the final keyword to classes that do not inherit?

Thanks for reading.

Checklist

  • I've read the Contribution Guidelines
  • My contributions are licensed under the Swift license.
  • I've followed the coding style of the rest of the project.
  • I've added tests covering all new code paths my change adds to the project (if appropriate).
  • I've added benchmarks covering new functionality (if appropriate).
  • I've verified that my change does not break any existing tests or introduce unexplained benchmark regressions.
  • I've updated the documentation if necessary.

@quokkaKyu quokkaKyu requested a review from lorentey as a code owner July 15, 2024 00:32
@lorentey lorentey added this to the 1.1.3 milestone Jul 17, 2024
@lorentey
Copy link
Member

@swift-ci test

@lorentey lorentey merged commit 293314a into apple:release/1.1 Jul 18, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants