Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CMake] Add support for WebAssembly target architectures #408

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

kateinoigakukun
Copy link
Contributor

@kateinoigakukun kateinoigakukun commented Jul 26, 2024

To repair the swift-corelibs-foundation build on WebAssembly, we need to add support for Wasm targets to swift-collections' CMake build system.

Checklist

  • I've read the Contribution Guidelines
  • My contributions are licensed under the Swift license.
  • I've followed the coding style of the rest of the project.
  • I've added tests covering all new code paths my change adds to the project (if appropriate).
  • I've added benchmarks covering new functionality (if appropriate).
  • I've verified that my change does not break any existing tests or introduce unexplained benchmark regressions.
  • I've updated the documentation if necessary.

@kateinoigakukun
Copy link
Contributor Author

@swift-ci test

Copy link
Member

@lorentey lorentey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Did you mean this to target the main branch instead of release/1.1?

@kateinoigakukun kateinoigakukun changed the base branch from main to release/1.1 August 1, 2024 00:29
To repair the swift-corelibs-foundation build on WebAssembly, we need to
add support for Wasm targets to swift-collections' CMake build system.
@kateinoigakukun
Copy link
Contributor Author

@lorentey You are right, this should target release/1.1. Thanks!

@lorentey lorentey added this to the 1.1.3 milestone Aug 1, 2024
@lorentey
Copy link
Member

lorentey commented Aug 1, 2024

@swift-ci test

@kateinoigakukun
Copy link
Contributor Author

@swift-ci test macOS

@kateinoigakukun kateinoigakukun merged commit 38602cf into apple:release/1.1 Aug 1, 2024
1 of 2 checks passed
@kateinoigakukun kateinoigakukun deleted the yt/wasm-archs branch August 1, 2024 16:02
@kateinoigakukun
Copy link
Contributor Author

Hi @lorentey, do we have any chance to release a new 1.1.x tag including this change? We need this change to repair Foundation build on Wasm. Thanks in advance 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants