ContainerRegistry: Switch to swift-http-types #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
euanh
force-pushed
the
use-swift-http-types
branch
from
818f647 to
861282b
Compare
euanh
force-pushed
the
use-swift-http-types
branch
3 times, most recently
from
f0c6ec0 to
fcd4884
Compare
euanh
force-pushed
the
use-swift-http-types
branch
from
fcd4884 to
f587ec9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Swift HTTP Types provides currency types for HTTP clients and servers, which can be used with URLSession and AsyncHTTPClient.
Generally speaking, we try to keep Swift Container Plugin's dependencies to a minimum because each dependency increases the initial build time and also increases the chance of a version conflict with the project which is trying to use the plugin. However
swift-http-typesis quite a small package and offers some nice ergonomic improvements overURLRequest/URLResponse, such as enums for HTTP status codes.Modifications
Switch all uses of
URLRequest/URLResponsetoHTTPRequest/HTTPResponseResult
No functional change.
Test Plan
The unit and integration tests continue to pass.