Examples: Update Package.resolved for Hummingbird #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This picks up an important fix in swift-async-algorithms 1.0.2
euanh
force-pushed
the
update-hummingbird-pins
branch
from
6dbf914 to
50c103a
Compare
euanh
added
area/documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Update Package.resolved, to pick up an important fix in swift-async-algorithms 1.0.2 which may prevent a crash in Hummingbird.
Modifications
Update Package.resolved in the Hummingbird example.
Result
The example will use newer dependencies.
Test Plan
The crash is intermittent but seems to happen after the server has been idle. A server built with the new pins has been idle without crashing for much longer than a server built with the old pins was able to run.