Add more Sendable annotations to Crypto Extras #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lukasa
requested changes
Dec 19, 2023
| @@ -18,7 +18,7 @@ import Foundation | |||
| extension AES { | |||
| /// The Advanced Encryption Standard (AES) Cipher Block Chaining (CBC) cipher | |||
| /// suite. | |||
| public enum _CBC { | |||
| public enum _CBC: Sendable { | |||
There was a problem hiding this comment.
This enum is uninhabited, it doesn't need a Sendable annotation.
There was a problem hiding this comment.
Ah, yep, good catch, I missed that on this pass.
| @@ -25,7 +25,7 @@ import Foundation | |||
| /// Types associated with the AES GCM SIV algorithm | |||
| extension AES.GCM { | |||
| /// AES in GCM SIV mode with 128-bit tags. | |||
| public enum _SIV { | |||
| public enum _SIV: Sendable { | |||
Motivation Add Sendable annotations to Crypto Extras to reflect current sandability so that downstream packages can implement sendable conformance. Modifications * Add Sendable conformance to some missed public symbols. * RSA public and private keys are now marked sendable with their backing storage on darwin OS marked unchecked sendable until SecKey from security framework has sendability annotations Result * More accurate Sendable annotations
rnro
force-pushed
the
Add_Sendable_annotations_to_Crypto_Extras
branch
from
90fcc20 to
f284a81
Compare
Lukasa
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Add Sendable annotations to Crypto Extras to reflect current sandability so that downstream packages can implement sendable conformance.
Modifications
Result