Change inclusiveMin param of ArbitraryPrecisionInteger.random from UInt64 to UInt #242
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently
ArbitraryPrecisionInteger.random(inclusiveMin:exclusiveMax:)
takes aUInt64
forinclusiveMin
and uses this for theBN_ULONG
parameter ofBN_rand_range_ex
, butBN_ULONG
isUInt32
on 32-bit platforms. For example, when compiling for "Any watchOS Simulator Device", we get the following compiler error:Modifications
Change
inclusiveMin
param ofArbitraryPrecisionInteger.random
fromUInt64
toUInt
.Result
Can now build on 32-bit platforms, where
BN_ULONG
isuint32_t
.