Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add iBeacon example for Pico W #69

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

colemancda
Copy link

@colemancda colemancda commented Nov 6, 2024

Updates the Pico W example to enable Bluetooth advertisements, advertising as an iBeacon in addition to its name and Bluetooth address.

Also adds some Swift wrappers for the Pico SDK.

Screenshot 2024-11-06 at 1 45 55 AM

@iCMDdev
Copy link
Contributor

iCMDdev commented Nov 7, 2024

Nice work! One remark: I think you changed the wrong description in the README - that’s the non-W pico’s link.

Also, while I’m not a code owner, I think it would be better to move this code to a separate example from the blink one (just like you did with the ESP example) - consider a beginner trying out Embedded Swift for the first time. I think they’d first want to try out a really simple blink example, and then move on to more complicated ones like yours.

Again, great work!🎉

@colemancda colemancda force-pushed the feature/pico-w-ibeacon branch from 9410adf to fcb79b8 Compare November 16, 2024 17:39
@colemancda colemancda changed the title Enable Bluetooth advertisement for Pico W Add iBeacon example for Pico W Nov 16, 2024
@colemancda
Copy link
Author

@iCMDdev I updated the branch and moved example to its own folder.

@rauhul
Copy link
Collaborator

rauhul commented Jan 3, 2025

Sorry about the radio silence on your PRs, I'm trying to figure out the best strategy for them. I'm not confident they are the best fit for this repo due to the sheer volume of code and the maintenance burden. I think a better solution would be to host these examples in a fork you own and we can link to them from the community section of the readme.

thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants