Skip to content

Make use of Swift 5.7 Duration and friends for Timer #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ktoso opened this issue Jul 19, 2022 · 0 comments · Fixed by #133
Closed

Make use of Swift 5.7 Duration and friends for Timer #114

ktoso opened this issue Jul 19, 2022 · 0 comments · Fixed by #133

Comments

@ktoso
Copy link
Member

ktoso commented Jul 19, 2022

We have time types in 5.7, let's use them in timer convenience APIs
@natikgadzhi natikgadzhi mentioned this issue Jun 23, 2023
Merged
5 tasks
tomerd pushed a commit that referenced this issue Jun 28, 2023
@natikgadzhi
Introducing Timer.record(_ duration:), closes #114 (#133)
13ea1fe 
Motivation:

`Duration` is available starting Swift 5.7, and we
should probably support it in our convinience API.

Modifications:
- Timer.record(_ duration: Duration) implementation
- A unit test case
- Generated Linux tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Introducing Timer.record(_ duration:), closes #114 natikgadzhi/swift-metrics
1 participant
@ktoso