Make 'values' on TestCounter, TestRecorder and TestMeter public #129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamzahrmalik
force-pushed
the
expose_test_metirc_values
branch
from
bf9d9a0 to
9a1d7c8
Compare
hamzahrmalik
force-pushed
the
expose_test_metirc_values
branch
from
9a1d7c8 to
e9df26c
Compare
ktoso
reviewed
May 26, 2023
| return Double(value) | ||
| } | ||
| return Double(value) / Double(displayUnit.scaleFromNanoseconds) | ||
| public func retrieveValueInPreferredUnit(atIndex i: Int) -> Double { |
There was a problem hiding this comment.
I wonder if just valueInPreferredUnit would be fine, while making this public?
ktoso
approved these changes
May 26, 2023
ktoso
approved these changes
May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make 'values' on TestCounter, TestRecorder and TestMeter public
Motivation:
TestTimeralready has a publicvalues: [Double]. We should also expose equivalent properties (with equivalent types) onTestCounter,TestRecorderandTestMeterModifications:
Change the existing
valuesproperty to have a type of[Int64]or[Double]to be equivalent to the existingTestTimer.valueswhich is[Double]. Then, make thesevaluesproperties publicResult:
Users can run assertions such as
values.count == 2to ensure the expected number of values were seen. Otherwise, they are limited to checking the lastValue only