add increment and decrement public API to Meter #132
Conversation
motivation: expose increment and decrement public APIs changes: * add increment and decrement public API to Meter * improve the implementation of AccumulatingMeter and TestMeter * add tests for new APIs * refactor/modernize other tests
| guard !amount.isNaN else { | ||
| return | ||
| } | ||
| // - cannot increment by infinite quantities | ||
| guard !amount.isInfinite else { | ||
| return | ||
| } | ||
| // - cannot increment by negative values | ||
| guard amount.sign == .plus else { | ||
| return | ||
| } | ||
| // - cannot increment by zero | ||
| guard !amount.isZero else { | ||
| return | ||
| } |
There was a problem hiding this comment.
Should we just silently return here or give the user any signal that he used an invalid value?
There was a problem hiding this comment.
we could make this throwing, but not sure if that make the call sites more cumbersome, note this is the default implementation, so in most cases the actual backend will drive the behavior
There was a problem hiding this comment.
I don't throwing makes sense here since it makes the API very awkward to use. I was more thinking if we should precondition this but that's probably also not a great idea. Overall, I am fine with just dropping them on the ground but wanted to raise the question.
There was a problem hiding this comment.
We could assert on this to ensure that debug builds fail.
There was a problem hiding this comment.
that is a good idea... but only when passing negative values? the rest may happen when the value is programmatically computed and that's fine - we dont want it to impact the meter.
motivation: expose increment and decrement public APIs
changes: