Fix tests on nghttp2-1.34.0 #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
Lukasa
requested changes
Nov 2, 2018
kevints
force-pushed
the
nghttp2-1.34-support
branch
from
a965052 to
21a42af
Compare
Motivation: nghttp2 changed the error code it returns when the server sends a GOAWAY. It's now `.cancelled` instead of `.refusedStream`. Modifications: Don't require a specific error code in the tests, just require that an error matching the expected stream ID occurred. Result: Tests will pass on nghttp2-1.34.0.
kevints
force-pushed
the
nghttp2-1.34-support
branch
from
21a42af to
8e273f8
Compare
Lukasa
approved these changes
Nov 2, 2018
Contributor
|
@swift-nio-bot test this please |
Contributor
|
Thanks @kevints! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
nghttp2 changed the error code it returns when the server sends a GOAWAY.
It's now
.cancelledinstead of.refusedStream.Modifications:
Don't require a specific error code in the tests, just require that an
error matching the expected stream ID occurred.
Result:
Tests will pass on nghttp2-1.34.0.