Make HTTP2StreamChannel non-generic #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: As part of the work done for apple#214 we made `HTTP2StreamChannel` generic over the type of data it reads and writes. Unfortunately this cost us a non-trivial amount of performance. Modifications: - Remove the genericism from 'HTTP2StreamChannel' by adding a mode for the stream data type the channel is operating on (frames or frame payloads), wrapping and unwrapping the data where necessary. - Simplify the implementation of 'MultiplexerAbstractChannel' - Remove 'HTTP2FrameConvertible' since it is no longer required Result: A perf win, hopefully.
|
@swift-nio-bot test this please |
Lukasa
approved these changes
Sep 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
As part of the work done for #214 we made
HTTP2StreamChannelgenericover the type of data it reads and writes. Unfortunately this cost us a
non-trivial amount of performance.
Modifications:
stream data type the channel is operating on (frames or frame
payloads), wrapping and unwrapping the data where necessary.
Result:
A perf win, hopefully.