Use the non-deprecated 'configureHTTP2Pipeline' in benchmarks #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: CI is spitting out a bunch of warnings about 'configureHTTP2Pipeline' being deprecated; it is called without providing the inbound stream state initializer. The non-deprecated version requires that this is explicitly passed as `nil`. Modifications: - Explicitly set the 'inboundStreamInitializer' to `nil` Result: Fewer warnings.
Lukasa
approved these changes
Sep 24, 2020
glbrntt
added a commit
to glbrntt/swift-nio-http2
that referenced
this pull request
Sep 24, 2020
) Motivation: CI is spitting out a bunch of warnings about 'configureHTTP2Pipeline' being deprecated; it is called without providing the inbound stream state initializer. The non-deprecated version requires that this is explicitly passed as `nil`. Modifications: - Explicitly set the 'inboundStreamInitializer' to `nil` Result: Fewer warnings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
CI is spitting out a bunch of warnings about 'configureHTTP2Pipeline'
being deprecated; it is called without providing the inbound stream state
initializer. The non-deprecated version requires that this is
explicitly passed as
nil.Modifications:
nilResult:
Fewer warnings.