Update alloc counter scaffolding. #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lukasa
force-pushed
the
cb-investigate-if-allocs-fail
branch
2 times, most recently
from
2b12468 to
a605cc5
Compare
Motivation: I have suspicions that the allocation counter tests in NIOHTTP2 don't fail properly, so let's bring the scaffolding up to date. Modifications: Update the few local files to the most recent NIO versions. Result: Smaller diffs to NIO, maybe better infrastructure?
Lukasa
force-pushed
the
cb-investigate-if-allocs-fail
branch
from
a605cc5 to
afa380f
Compare
Lukasa
changed the title
glbrntt
approved these changes
Sep 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
I have suspicions that the allocation counter tests in NIOHTTP2 don't
fail properly, so let's bring the scaffolding up to date.
Modifications:
Update the few local files to the most recent NIO versions.
Result:
Smaller diffs to NIO, maybe better infrastructure?