Add benchmark and alloc test for GOAWAY teardown. #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: We don't have any benchmarks or alloc counter tests for doing stream teardown with GOAWAY frames. While this isn't a terribly hot code path and isn't terribly performance heavy with allocations, it's good to have more data here. Modifications: - Write benchmarks and alloc counter tests that tear down many streams with GOAWAY. Result: Better testing and alloc counter.
Lukasa
force-pushed
the
cb-bench-goaway-teardown
branch
from
4470553 to
47b2a1a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
We don't have any benchmarks or alloc counter tests for doing stream
teardown with GOAWAY frames. While this isn't a terribly hot code path
and isn't terribly performance heavy with allocations, it's good to have
more data here.
Modifications:
with GOAWAY.
Result:
Better testing and alloc counter.