Remove some generics that were triggering ARC #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: To save myself some lines of code I wrote a function that was generic over a protocol to copy out a pair of fields from a wide range of types. It turns out this generic was triggering a retain/release on the state machine states, which triggers 12 ARC operations total (6 retain/release pairs). Removing this generic and just, you know, calling a function with some arguments turns out to save us a bunch of this ARC traffic. Modifications: - Remove the generic initializer of StateMachineResultWithEffect. Result: Approximately 1% performance improvement in hot benchmarks.
Lukasa
added
kind/enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
To save myself some lines of code I wrote a function that was generic
over a protocol to copy out a pair of fields from a wide range of types.
It turns out this generic was triggering a retain/release on the state
machine states, which triggers 12 ARC operations total (6 retain/release
pairs).
Removing this generic and just, you know, calling a function with some
arguments turns out to save us a bunch of this ARC traffic.
Modifications:
Result:
Approximately 1% performance improvement in hot benchmarks.