Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker setup for main nightlies #277

Merged
merged 3 commits into from
May 4, 2021
Merged

docker setup for main nightlies #277

merged 3 commits into from
May 4, 2021

Conversation

weissi
Copy link
Member

@weissi weissi commented Feb 17, 2021

No description provided.

PeterAdams-A
PeterAdams-A approved these changes Feb 17, 2021
View reviewed changes
Copy link
Contributor

@PeterAdams-A PeterAdams-A left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems sensible.

@weissi weissi requested a review from tomerd February 17, 2021 12:50
@tomerd
Copy link
Member

tomerd commented Mar 2, 2021

@swift-server-bot test this please

2 similar comments
@tomerd
Copy link
Member

tomerd commented Mar 2, 2021

@swift-server-bot test this please

@tomerd
Copy link
Member

tomerd commented Mar 2, 2021

@swift-server-bot test this please

@Lukasa
Copy link
Contributor

Lukasa commented Mar 16, 2021

@weissi Seems like the nightly is failing due to TSAN being busted, want to disable it?

@tomerd
Copy link
Member

tomerd commented Mar 16, 2021 •
edited
Loading

@weissi Seems like the nightly is failing due to TSAN being busted, want to disable it?

this is an issue we have on all ubuntu docker images > 16.04 on the kernel we run on CI hosts. yet to figure it out :/

@weissi
Copy link
Member Author

weissi commented Mar 16, 2021

this is an issue we have on all ubuntu docker images > 16.04 on the kernel we run on CI hosts. yet to figure it out :/

@tomerd I think on 5.4 it's even worse and it doesn't even work on 16.04, I think I tried with NIO...

Lukasa
Lukasa requested changes Mar 17, 2021
View reviewed changes
Copy link
Contributor

@Lukasa Lukasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs substantial changes. The image name is wrong (you have swift-nio but it should be swift-nio-http2, and you're missing a h2spec_version directive in runtime-setup.

@Lukasa Lukasa added the semver/none No version bump required. label Mar 17, 2021
@weissi weissi force-pushed the jw-docker-main branch from 1ff7c23 to 2f226cc Compare May 4, 2021 18:20
@weissi weissi requested review from PeterAdams-A and Lukasa May 4, 2021 18:20
@weissi weissi force-pushed the jw-docker-main branch from 2f226cc to b44014f Compare May 4, 2021 18:20
@weissi
Copy link
Member Author

weissi commented May 4, 2021

@Lukasa sorry this took so long, missed your comments. Updated

@weissi weissi force-pushed the jw-docker-main branch from b44014f to 056f760 Compare May 4, 2021 18:52
@Lukasa Lukasa merged commit cec5d4b into apple:main May 4, 2021
@weissi weissi deleted the jw-docker-main branch May 4, 2021 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lukasa Lukasa Lukasa approved these changes

@tomerd tomerd Awaiting requested review from tomerd

@PeterAdams-A PeterAdams-A Awaiting requested review from PeterAdams-A

Assignees
No one assigned
Labels
semver/none No version bump required.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@weissi @tomerd @Lukasa @PeterAdams-A