Add sync option support to HTTP2StreamChannel #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lukasa
approved these changes
Mar 15, 2021
| } | ||
| } | ||
|
|
||
| private func setOption0<Option: ChannelOption>(_ option: Option, value: Option.Value) throws { | ||
| assert(eventLoop.inEventLoop) | ||
| self.eventLoop.assertInEventLoop() |
There was a problem hiding this comment.
As these are now called publicly through APIs where the user is required to get them correct, I think we should lift these up to preconditions.
Lukasa
requested changes
Mar 15, 2021
glbrntt
force-pushed
the
gb-add-sync-options
branch
from
7cfb8cf to
320e4a3
Compare
|
All the CI -- except for the nightly job, which is expected to fail -- run without failures until they hit an issue reporting the status. |
Lukasa
requested changes
Mar 15, 2021
Motivation: SwiftNIO 2.27.0 added support for synchronous channel options allowing callers to get options synchronously -- saving a future allocation -- if they know they're on the correct event loop. 'HTTP2StreamChannel' should support this. Modifications: - Add 'HTTP2StreamChannel.SynchronousOptions' with conformance to 'NIOSynchronousChannelOptions' Result: Callers can get and set options synchronously on 'HTTP2StreamChannel'
glbrntt
force-pushed
the
gb-add-sync-options
branch
from
320e4a3 to
7c2c119
Compare
Lukasa
approved these changes
Mar 15, 2021
|
@swift-nio-bot test this please |
|
Merging over the nightly failure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
SwiftNIO 2.27.0 added support for synchronous channel options allowing
callers to get options synchronously -- saving a future allocation -- if
they know they're on the correct event loop. 'HTTP2StreamChannel' should
support this.
Modifications:
'NIOSynchronousChannelOptions'
Result:
Callers can get and set options synchronously on 'HTTP2StreamChannel'