Use sync options when creating a stream channel #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: SwiftNIO 2.27.0 added synchronous channel options. We can use these if available when creating a stream channel to avoid a future allocation. Modifications: - 'getAutoReadFromParent' is synchronous when possible and now takes a closure to handle the result. - Update allocation counts (and sort them to make updating them easier, this also includes switching the order we run test_1k_requests interleaved and noninterleaved) Result: Fewer allocations.
glbrntt
force-pushed
the
gb-use-sync-options
branch
from
946faab to
b8cf750
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
SwiftNIO 2.27.0 added synchronous channel options. We can use these if
available when creating a stream channel to avoid a future allocation.
Modifications:
closure to handle the result.
this also includes switching the order we run test_1k_requests
interleaved and noninterleaved)
Result:
Fewer allocations.