Stop using deprecated API in allocation counting tests #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glbrntt
commented
Mar 16, 2021
docker/docker-compose.1604.51.yaml
Outdated
| @@ -19,8 +19,8 @@ services: | |||
| - MAX_ALLOCS_ALLOWED_1k_requests_interleaved=53000 | |||
| - MAX_ALLOCS_ALLOWED_1k_requests_noninterleaved=52000 | |||
| - MAX_ALLOCS_ALLOWED_client_server_h1_request_response=336000 | |||
| - MAX_ALLOCS_ALLOWED_client_server_request_response=300000 | |||
| - MAX_ALLOCS_ALLOWED_create_client_stream_channel=55000 | |||
| - MAX_ALLOCS_ALLOWED_client_server_request_response=310000 | |||
There was a problem hiding this comment.
The regression here is the 'pending streams' dictionary in the multiplexer resizing (it isn't used for the frame-based stream channels).
Lukasa
approved these changes
Mar 16, 2021
Motivation: Some of the allocation counting tests used frame-based stream channels rather than the frame payload based ones. These were deprecated some time ago. Modifications: - Update test handlers to be `HTTP2Frame.FramePayload` based - Update the 'create_client_stream_channel' test to count streams rather than summing their stream ID (as stream IDs aren't assigned until the stream channel delivers pending writes for the first time). - Update allocation limits Result: Allocation counting tests don't use deprecated APIs.
glbrntt
force-pushed
the
gb-fixup-warnings
branch
from
935757e to
9e81939
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Some of the allocation counting tests used frame-based stream channels
rather than the frame payload based ones. These were deprecated some
time ago.
Modifications:
HTTP2Frame.FramePayloadbasedthan summing their stream ID (as stream IDs aren't assigned until the
stream channel delivers pending writes for the first time).
Result:
Allocation counting tests don't use deprecated APIs.