Add support for Ubuntu 16.04's packaged nghttp2. #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: We'd done all our development against newer copies of nghttp2, that behaved a bit differently. We should support Ubuntu's copy, at least while nghttp2 is relevant to us. Modifications: - Shimmed over a version difference. - Fixed the tests to stop relying on differences. - Removed the Swift 4.0.3 dockerfiles as we don't support Swift 4.0 anyway. Result: Users can build against Ubuntu 16.04's nghttp2 package.
weissi
reviewed
Dec 4, 2018
| args: | ||
| ubuntu_version : "16.04" | ||
| swift_version : "4.0.3" | ||
| install_nghttp2_from_source: "true" |
Member
There was a problem hiding this comment.
why are we removing the whole docker yamls here?
Contributor
Author
There was a problem hiding this comment.
Because we don't support Swift 4.0, and never have. This is mentioned in the commit message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
We'd done all our development against newer copies of nghttp2, that
behaved a bit differently. We should support Ubuntu's copy, at least
while nghttp2 is relevant to us.
Modifications:
4.0 anyway.
Result:
Users can build against Ubuntu 16.04's nghttp2 package.