Bump Swift version in build_podspec.sh #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: SwiftNIO recently dropped support for Swift 5.0 and Swift 5.1 but our build_podspec.sh script doesn't reflect this change. Additionally the list_topsorted_dependencies.sh script always assumed named depenencies when listing module depenencies. Since our tools version has now been bumped to 5.2 that's no longer the case and the script produces a bunch of nulls which throws the build_podspec.sh script off course. Modifications: - Bump the Swift version in build_podspec.sh to 5.2 - Include "product" dependencies when listing module dependencies in list_topsorted_dependencies.sh Result: Podspecs are created as expected
Davidde94
approved these changes
Jul 6, 2021
Lukasa
approved these changes
Jul 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
SwiftNIO recently dropped support for Swift 5.0 and Swift 5.1 but our
build_podspec.sh script doesn't reflect this change. Additionally the
list_topsorted_dependencies.sh script always assumed named depenencies
when listing module depenencies. Since our tools version has now been
bumped to 5.2 that's no longer the case and the script produces a bunch
of nulls which throws the build_podspec.sh script off course.
Modifications:
list_topsorted_dependencies.sh
Result:
Podspecs are created as expected