HTTP2ToHTTP1Codec: Fix receiving empty .body before .end #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianfett
force-pushed
the
ff-fix-empty-byte-buffer-before-end
branch
from
a033b94 to
65e241c
Compare
glbrntt
approved these changes
Aug 12, 2021
Lukasa
approved these changes
Aug 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently if a peer sends an empty
dataPayloadthat signals the stream's end, the HTTP2ToHTTP1Codec will issue a HTTP1.bodywith an emptyByteBufferand an HTTP1.end. The HTTP1.bodywith the empty byte buffer can be saved.Changes
The
BaseClientCodecwas changed in such a way, that an emptydataPayloadthat signals the stream's end, will only create a HTTP1.end.Result
Fewer empty
byteBuffers.