Inline http2 fixups #402
Merged
Inline http2 fixups #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glbrntt
reviewed
Jul 3, 2023
Comment on lines
308
to
310
| private func _commonHTTPServerPipeline(configurator: @escaping (Channel) -> EventLoopFuture<Void>, | ||
| h2ConnectionChannelConfigurator: ((Channel) -> EventLoopFuture<Void>)?, | ||
| configureHTTP2Pipeline: @escaping (Channel) -> EventLoopFuture<T>) -> EventLoopFuture<Void> { | ||
| configureHTTP2Pipeline: @escaping (Channel) -> EventLoopFuture<Void>) -> EventLoopFuture<Void> { |
There was a problem hiding this comment.
nit: indentation is inconsistent now
glbrntt
reviewed
Jul 3, 2023
| h2ConnectionChannelConfigurator: ((Channel) -> EventLoopFuture<Void>)?, | ||
| configureHTTP2Pipeline: @escaping (Channel) -> EventLoopFuture<Void> | ||
| ) -> EventLoopFuture<Void> { | ||
| let h2ChannelConfigurator = { (channel: Channel) -> EventLoopFuture<Void> in |
There was a problem hiding this comment.
Don't hate me but this line is now over-indented...
Suggested change
| let h2ChannelConfigurator = { (channel: Channel) -> EventLoopFuture<Void> in | |
| let h2ChannelConfigurator = { (channel: Channel) -> EventLoopFuture<Void> in |
There was a problem hiding this comment.
Fixing minutia is what this is all about
There was a problem hiding this comment.
Don't hate me but that should be minutiae, minutia is singular.
There was a problem hiding this comment.
🤦 Getting that correct was my only criterion too
glbrntt
approved these changes
Jul 3, 2023
* remove redundant generics * rename variables `clientHandler` -> `clientMultiplexer` where appropriate
glbrntt
approved these changes
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few places where bugs / poorly structured code crept in during the inline multiplexer work. This attempts to address some of them: