Fix parent channel read() call on HTTP2StreamChannel initialization causing incorrect order of inbound HTTP2Frames
#413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FranzBusch
reviewed
Jul 26, 2023
Comment on lines
112
to
116
| channel.configureInboundStream(initializer: self.inboundStreamStateInitializer) | ||
| channel.receiveInboundFrame(frame) | ||
| channel.configureInboundStream(initializer: self.inboundStreamStateInitializer) |
There was a problem hiding this comment.
This is quite subtle. Can we add a comment here that this order is important.
Lukasa
requested changes
Jul 27, 2023
|
@swift-server-bot test this please |
|
@swift-server-bot test this please |
|
Locally your test crashes for me: |
@Lukasa looking into this... |
|
@Lukasa Apparently caused by the switch to the non-deprecated |
…on causing incorrect order of inbound `HTTP2Frame`s Motivation: Make sure the order of `HTTP2Frame`s that are fired through the pipeline of a `HTTP2StreamChannel` by `HTTP2CommonInboundStreamMultiplexer` is correct when a `read()` call on the parent channel synchronously causes further frames to be processed. Modifications: Reorder calls in `HTTP2CommonInboundStreamMultiplexer.receivedFrame(frame:context:multiplexer)` so that initial header frame is buffered and processed first. Result: Resolves apple#410 and makes newly added test case `HTTP2StreamMultiplexerTests.testMultiplexerFiresInitialFramesInCorrectOrder()` pass.
|
@swift-server-bot test this please if I'm allowed to trigger that |
|
@swift-server-bot add to allowlist |
Lukasa
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Make sure the order of
HTTP2Frames that are fired through the pipeline of aHTTP2StreamChannelbyHTTP2CommonInboundStreamMultiplexeris correct when aread()call on the parent channel synchronously causes further frames to be processed.Modifications:
Reorder calls in
HTTP2CommonInboundStreamMultiplexer.receivedFrame(frame:context:multiplexer)so that initial header frame is buffered and processed first.Result:
Resolves #410 and makes newly added test case
HTTP2StreamMultiplexerTests.testMultiplexerFiresInitialFramesInCorrectOrder()pass.