Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dependency on SPI #419

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Remove dependency on SPI #419

merged 1 commit into from
Oct 4, 2023

Conversation

rnro
Copy link
Contributor

@rnro rnro commented Oct 4, 2023

Motivation:

Remove dependency on SPI so that we can cut a release without introducing dependency on code subject to change.

Modifications:

Remove all code which introduces a dependency on the NIOAsyncChannel SPI

Result:

Code inside SPI is removed

@rnro
Remove dependency on SPI
bc2acbe 
Motivation:

Remove dependency on SPI so that we can cut a release without
introducing dependency on code subject to change.

Modifications:

Remove all code which introduces a dependency on the NIOAsyncChannel SPI

Result:

Code inside SPI is removed
@rnro rnro requested a review from FranzBusch October 4, 2023 10:56
@glbrntt
Copy link
Contributor

glbrntt commented Oct 4, 2023

Not actually breaking as it's unreleased SPI.

@glbrntt glbrntt merged commit 2140160 into apple:main Oct 4, 2023
@rnro rnro added the semver/none No version bump required. label Oct 10, 2023
rnro added a commit to rnro/swift-nio-http2 that referenced this pull request Oct 11, 2023
@rnro
Reintroduce Async Channel SPI
03f1a82 
We previously removed Async Channel SPI to allow a clean release without
adding dependency on NIO code which was subject to change, however that
code is now ready to be promoted to API.

Revert "Remove dependency on SPI (apple#419)"

This reverts commit 2140160.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FranzBusch FranzBusch FranzBusch approved these changes

Assignees
No one assigned
Labels
semver/none No version bump required.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rnro @glbrntt @FranzBusch