Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing availability guards in tests #429

Conversation

simonjbeaumont
Copy link
Contributor

Motivation

Some of the test code was missing availability guards for Apple platforms, resulting in build failures for these platforms, e.g.

error: 'NIOAsyncTestingChannel' is only available in iOS 13.0 or newer
         var clientChannel: NIOAsyncTestingChannel!

Modifications

Add missing availability guards. I've tried to keep them as scoped as possible. Some test suites used these as class properties, so these got a guard at suite level.

Result

Tests can now build and run on iOS and other Apple platforms.

Copy link
Contributor

@glbrntt glbrntt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good but there's a heap of failures from using deprecated API (as warnings as errors is enabled in CI), we should fix that up separately.

@simonjbeaumont
Copy link
Contributor Author

This looks good but there's a heap of failures from using deprecated API (as warnings as errors is enabled in CI), we should fix that up separately.

Looks like they all might be coming from one test. Added a commit which might fix it.

@simonjbeaumont simonjbeaumont merged commit 28a91a3 into apple:main Dec 15, 2023
8 checks passed
@glbrntt glbrntt added the semver/none No version bump required. label Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver/none No version bump required.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants