Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Bionic module from new Android overlay in Swift 6 instead #448

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

finagolfin
Copy link
Contributor

Swift 6 has switched to this new Android overlay, swiftlang/swift#74758, which I've been testing on this repo without a problem using my daily Android CI for weeks now, finagolfin/swift-android-sdk#151.

Copy link
Contributor

@glbrntt glbrntt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@glbrntt glbrntt added the semver/none No version bump required. label Jul 12, 2024
@glbrntt glbrntt enabled auto-merge (squash) July 12, 2024 14:59
@FranzBusch
Copy link
Member

@swift-server-bot add to allowlist

@FranzBusch
Copy link
Member

@swift-server-bot test this please

1 similar comment
@glbrntt
Copy link
Contributor

glbrntt commented Jul 15, 2024

@swift-server-bot test this please

@glbrntt glbrntt merged commit cbdbc9c into apple:main Jul 15, 2024
6 of 7 checks passed
@finagolfin finagolfin deleted the droid branch July 15, 2024 07:44
Lukasa pushed a commit that referenced this pull request Oct 30, 2024
I added the `Bionic` import this summer in #448 and the compiler
accepted it then, but it started erroring a couple months later without
this full Android overlay, so add that instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver/none No version bump required.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants