Propagate ChannelShouldQuiesceEvent to child channels #464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: NIO has a 'ChannelShouldQuiesceEvent' which channels can listen for in order to know when they should quiesce. This is typically used to initiate a graceful shutdown of an HTTP/2 server. However, child channels aren't notified of this event so HTTP/2 servers must keep track of streams separately in order to notify them when the server is quiescing. Modifications: - Propagate the `ChannelShouldQuiesceEvent` to child channels Result: Child channels can watch for `ChannelShouldQuiesceEvent`s
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
NIO has a 'ChannelShouldQuiesceEvent' which channels can listen for in order to know when they should quiesce. This is typically used to initiate a graceful shutdown of an HTTP/2 server. However, child channels aren't notified of this event so HTTP/2 servers must keep track of streams separately in order to notify them when the server is quiescing.
Modifications:
ChannelShouldQuiesceEventto child channelsResult:
Child channels can watch for
ChannelShouldQuiesceEvents