GitHub Actions to parity with existing CI #469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Want to move away from legacy CI. Modifications: Add configuration and update code to use GitHub actions. Result: GitHub Actions can be used for basic CI.
FranzBusch
reviewed
Oct 23, 2024
.github/workflows/main.yml
Outdated
Comment on lines
12
to
14
| linux_5_9_arguments_override: "--explicit-target-dependency-import-check error" | ||
| linux_5_10_arguments_override: "--explicit-target-dependency-import-check error" | ||
| linux_6_0_arguments_override: "--explicit-target-dependency-import-check error" |
There was a problem hiding this comment.
What about warnings as errors?
There was a problem hiding this comment.
Added (but not 6 as that isn't clean).
.unacceptablelanguageignore
Outdated
| @@ -0,0 +1,3 @@ | |||
| IntegrationTests/run-tests.sh | |||
There was a problem hiding this comment.
Can you use line based ignores here instead please by adding # ignore-unacceptable-language to the lines.
.unacceptablelanguageignore
Outdated
| @@ -0,0 +1,3 @@ | |||
| IntegrationTests/run-tests.sh | |||
| Tests/hpack-test-case/*/story_20.json | |||
| scripts/test_h2spec.sh | |||
FranzBusch
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Want to move away from legacy CI.
Modifications:
Add configuration and update code to use GitHub actions.
Result:
GitHub Actions can be used for basic CI.