Skip to content

Conversation

@glbrntt
Copy link
Contributor

@glbrntt glbrntt commented Feb 28, 2025

Motivation:

The maximum number of recently reset stream frames to track is limited to a fixed value of 32. This should be configurable.

Modifications:

  • Add it to the connection config and propagate it through

Result:

Motivation:

The maximum number of recently reset stream frames to track is limited
to a fixed value of 32. This should be configurable.

Modifications:

- Add it to the connection config and propagate it through

Result:

- Resolves apple#493
@glbrntt glbrntt requested a review from Lukasa February 28, 2025 13:24
@glbrntt glbrntt added the 🆕 semver/minor Adds new public API. label Feb 28, 2025
Copy link
Contributor

@Lukasa Lukasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, LGTM.

@Lukasa Lukasa merged commit 1251530 into apple:main Feb 28, 2025
39 checks passed
@glbrntt glbrntt deleted the recently-reset-streams branch April 7, 2025 09:10
gjcairo added a commit to grpc/grpc-swift that referenced this pull request Apr 29, 2025
We have exposed the max reset stream frames config in NIO H2
(apple/swift-nio-http2#494) - we need to add
configuration to expose it in gRPC v1 as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🆕 semver/minor Adds new public API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow maxResetStreams to be configured

2 participants