Update main.yml integration tests to use swift_test_matrix #499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update main.yml integration tests to use `swift_test_matrix` as has been done on the PR workflow. This brings it off the deprecated workflow and should fix the nightly-6.1 issue
rnro
commented
Mar 10, 2025
czechboy0
reviewed
Mar 10, 2025
.github/workflows/main.yml
Outdated
| name: "HTTP/2 spec tests" | ||
| matrix_linux_command: "apt-get update -y -q && apt-get install -y -q wget lsof && mkdir $HOME/.tools && wget -q https://github.com/summerwind/h2spec/releases/download/v2.2.1/h2spec_linux_amd64.tar.gz -O $HOME/.tools/h2spec.tar.gz && tar xzf $HOME/.tools/h2spec.tar.gz --directory $HOME/.tools && PATH=${PATH}:$HOME/.tools && ./scripts/test_h2spec.sh" | ||
|
|
||
| construct-integration-tests-matrix: |
There was a problem hiding this comment.
Should the name be indented 2 spaces to the left?
Contributor
Author
There was a problem hiding this comment.
Looks that way, thanks!
rnro
commented
Mar 14, 2025
czechboy0
approved these changes
Mar 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update main.yml integration tests to use
swift_test_matrixas has been done on the PR workflow. This brings it off the deprecated workflow and should fix the nightly-6.1 issue