Skip to content

Enable warnings as errors #517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 14, 2025
Merged

Enable warnings as errors #517

merged 2 commits into from
May 14, 2025

Conversation

@gjcairo
Copy link
Contributor

@gjcairo gjcairo commented May 14, 2025

No description provided.

@gjcairo gjcairo added the 🔨 semver/patch No public API change. label May 14, 2025
@gjcairo gjcairo marked this pull request as ready for review May 14, 2025 13:07
rnro
rnro approved these changes May 14, 2025
View reviewed changes
Copy link
Contributor

@rnro rnro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🚀

@gjcairo gjcairo merged commit 623755c into apple:main May 14, 2025
38 of 39 checks passed
@gjcairo gjcairo deleted the warns-as-errors branch May 14, 2025 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rnro rnro rnro approved these changes

Assignees

No one assigned

Labels

🔨 semver/patch No public API change.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gjcairo @rnro