Skip to content

ChannelInvoker.newPromise should pass file and line to eventLoop.newPromise #202

Closed
@Lukasa

Description

@Lukasa

We normally want debugging information to keep track of where our promises are allocated in debug modes. However, if someone does Channel.newPromise instead of eventLoop.newPromise, that information is lost. The core issue is here:

private func newPromise() -> EventLoopPromise<Void> {
return eventLoop.newPromise()
}

This indirection should preserve the #file and #line specific debugging logic we use elsewhere.

Metadata

Metadata

Assignees

No one assigned

    Labels

    good first issueGood for newcomerskind/bugFeature doesn't work as expected.

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions