-
Notifications
You must be signed in to change notification settings - Fork 652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make ByteBuffer.description useful and pretty #2863
Comments
Onboard with this idea. The current description is not really helpful in most cases and I always do a hexDump manually while debugging. We should also change the |
Normally I'd say that we shouldn't change |
Yes |
I can pick this one up also 👋 |
@weissi since @FranzBusch mentioned here that |
Good! Then please approve: #2495 |
Motivation: Resolving the following issue: apple#2863 Modifications: Rewrote `description` and `debugDescription` on `ByteBuffer` to make it more useful. Result: A more userful `description` and `debugDescription`. After your change, what will change.
Here it is |
### Motivation: Resolving the following issue: #2863 ### Modifications: Rewrote `description` and `debugDescription` on `ByteBuffer` to make it more useful. Also fixed a bug in the in `hexDumpCompact`. ### Result: A more useful `description` and `debugDescription`. --------- Co-authored-by: Franz Busch <f.busch@apple.com>
Right now,
ByteBuffer
'sdescription
is ugly and not very useful (doesn't print the bytes). With #2856 being merged, I'm proposing to makeByteBuffer
's description the following:so
hello world
would beand 256 0 bytes would be
the empty string would be
[](0 bytes)
The text was updated successfully, but these errors were encountered: