Fix warnings in tests. #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: When running swift test two warnings were printed. Modifications: - Signal that we want to ignore the return value - Use boolean test in the while loop Result: Cleaner build
Lukasa
approved these changes
Mar 19, 2018
weissi
pushed a commit
to weissi/swift-nio
that referenced
this pull request
Jun 13, 2020
…rotocol (apple#193) Motivation: Applications might want to support H2 (when available) and HTTP1 (as a fallback). The application logic should not change between the two versions of the protocol and the code to configure support for both the protocols is boilerplate and can be provided as an helper function. Modifications: This PR adds an helper function to configure HTTP1 or H2 pipelines according to the protocol negotiated by the TLS handler. Result: Applications that need to support clients using both HTTP1 and H2 can configure their channels by calling `configureCommonHTTPServerPipeline`, which should reduce the boilerplate they have to write. Co-Authored-By: Cory Benfield <lukasa@apple.com>
weissi
pushed a commit
to weissi/swift-nio
that referenced
this pull request
Feb 3, 2024
# Motivation Currently the `QuiescingHelper` is crashing on a precondition if you call shutdown when it already was shutdown. However, that can totally happen and we should support it. # Modification Refactor the `QuiescingHelper` to exhaustively switch over its state in every method. Furthermore, I added a few more test cases to test realistic scenarios. # Result We are now reliable checking our state and making sure to allow most transitions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
When running swift test two warnings were printed.
Modifications:
Result:
Cleaner build