Better docs for threading guarantees of futures #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sources/NIO/EventLoopFuture.swift
Outdated
| /// | ||
| /// One of the major performance advantages of NIO over something like Node.js or Python’s asyncio is that NIO will | ||
| /// by default run multiple event loops at once, on different threads. As most network protocols do not require | ||
| /// blocking operation, at least in their low level implementations, this provides enormous speed ups on machines |
There was a problem hiding this comment.
I am not a native speaker but I think it should be either speed-ups or speedups.
normanmaurer
approved these changes
Mar 20, 2018
Lukasa
force-pushed
the
cb-future-threading-doc
branch
from
a49abe4 to
f4e731c
Compare
|
LGTM... let us wait for @weissi |
|
Thanks... merged |
weissi
pushed a commit
to weissi/swift-nio
that referenced
this pull request
Jun 13, 2020
Motivation: Sometimes it's useful to be able to print out objects and see their internal state. Somehow, HTTP2Handler can't do this. Modifications: Add a conformance to HTTP2Handler. Result: Awesome debugging output.
weissi
pushed a commit
to weissi/swift-nio
that referenced
this pull request
Feb 3, 2024
Motivation Per SwiftNIO's formal version policy, we are ready to drop support for Swift 5.5. Modifications This patch removes the support for 5.5 and all supporting infrastructure. This includes the test generation functionality, which is no longer required, as well as the files generated by that functionality. It updates the dockerfile for 5.8, and it removes all conditional compilation checks that are now definitionally true. Result A nice, clean, 5.6+ codebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It occurred to me that we probably needed better narrative docs for the threading guarantees of
EventLoopFuture, so I whipped these up over the weekend. Take a look, let me know what you think.