Dissallow access and removal of Head and Tail ChannelHandlers #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
normanmaurer
force-pushed
the
pipeline_head_tail
branch
from
a301bec to
0468cc2
Compare
Lukasa
requested changes
Mar 23, 2018
| } | ||
|
|
||
| do { | ||
| _ = try channel.pipeline.context(name: "head").wait() |
There was a problem hiding this comment.
Might be better to look for these handlers by type, as we couldn't fix that by just removing their names.
There was a problem hiding this comment.
added an extra assert for that
normanmaurer
force-pushed
the
pipeline_head_tail
branch
from
0468cc2 to
57f8d99
Compare
|
@Lukasa PTAL again |
Lukasa
requested changes
Mar 23, 2018
Sources/NIO/ChannelPipeline.swift
Outdated
| /// | ||
| /// - parameters: | ||
| /// - body: The predicate to execute per `ChannelHandlerContext` in the `ChannelPipeline`. | ||
| /// -returns: The `ChannelHandlerContext` that matches or `nil` if non did. |
There was a problem hiding this comment.
We should note that this returns the first ChannelHandlerContext that matches, not the only one.
normanmaurer
force-pushed
the
pipeline_head_tail
branch
from
57f8d99 to
d04ee22
Compare
Lukasa
reviewed
Mar 23, 2018
Sources/NIO/ChannelPipeline.swift
Outdated
| @@ -446,9 +446,16 @@ public final class ChannelPipeline: ChannelInvoker { | |||
| return promise.futureResult | |||
| } | |||
|
|
|||
| /// Returns a `ChannelHandlerContext` which matches. | |||
| /// | |||
| /// This skips head and tail (as these are internal and should not be accessible by the user. | |||
Motivation: The Head and Tail ChannelHandlers should not be accessible as these are implementation details of the ChannelPipeline and removal of these will even make the whole ChannelPipeline not work anymore. Modifications: - Make it impossible to access / removal the Head and Tail ChannelHandlers - Exclude the Head and Tail ChannelHandler from the debug String - Add unit tests. Result: More robust ChannelPipeline.
normanmaurer
force-pushed
the
pipeline_head_tail
branch
from
d04ee22 to
8824fe3
Compare
Lukasa
approved these changes
Mar 23, 2018
normanmaurer
added
kind/bug
|
@Lukasa thanks for the review... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The Head and Tail ChannelHandlers should not be accessible as these are implementation details of the ChannelPipeline and removal of these will even make the whole ChannelPipeline not work anymore.
Modifications:
Result:
More robust ChannelPipeline.