Remove one pair of lock() / unlock() during EventLoop run. #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
less locking FTW 🎉 |
normanmaurer
force-pushed
the
remove_lock
branch
from
de05774 to
4f6bf76
Compare
Lukasa
previously requested changes
Mar 26, 2018
Sources/NIO/EventLoop.swift
Outdated
| } | ||
|
|
||
| let cnt = tasksCopy.count |
There was a problem hiding this comment.
Why did this move into the lock?
There was a problem hiding this comment.
@Lukasa because I am stupid... let me fix this its not needed.
Motivation: We can remove one lock() / unlock() pair by saving the next ready task during loop execution. Modifications: Remvoe one lock() / unlock() pair. Result: Less locking during EventLoop run executions.
normanmaurer
force-pushed
the
remove_lock
branch
from
4f6bf76 to
0a8ba30
Compare
|
I will merge once the CI completes :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
We can remove one lock() / unlock() pair by saving the next ready task during loop execution.
Modifications:
Remvoe one lock() / unlock() pair.
Result:
Less locking during EventLoop run executions.