Fix flaky test in NIOAsyncWriter #2431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lukasa
approved these changes
May 22, 2023
|
Seems like a nightly allocation regression, mind fixing it up? |
FranzBusch
force-pushed
the
fb-fix-writer-tests
branch
2 times, most recently
from
4957a9c to
171f4a9
Compare
|
@swift-server-bot test this please |
# Motivation We had flaky test in the writer where we were relying on some timing. # Modification Change the test so that it is deterministic. # Result Fixes apple#2427
FranzBusch
force-pushed
the
fb-fix-writer-tests
branch
from
171f4a9 to
cd9bd63
Compare
FranzBusch
force-pushed
the
fb-fix-writer-tests
branch
from
cd9bd63 to
69ce691
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We had flaky test in the writer where we were relying on some timing.
Modification
Change the test so that it is deterministic.
Result
Fixes #2427