Add support for Musl libc #2449
Conversation
Since Musl is sufficiently different from Glibc (see https://wiki.musl-libc.org/functional-differences-from-glibc.html), it requires a different import, which now should be applied to files that have `import Glibc` in them.
|
Can we get some CI setup for this, otherwise I see us regressing really fast here. @MaxDesiatov is there any docker image we can use? |
|
There's no Docker image right now as toolchain PRs aren't ready yet. I'm fine with this regressing until that's sorted out, I'm submitting this PR primarily to simplify local builds for development. Maintaining patches and branches manually across a dozen of repositories is unwieldy and I'd rather have these small changes merged ASAP so that iterating on the toolchain locally is easier. |
|
There are some mistakes in this pull, which just broke my Android CI. Android uses I will submit a pull correcting those later today. |
…if libc not found Motivation Fix build errors on Android Modifications - Fix previous Musl modifications that assumed Glibc wasn't imported on Android - Add errors for all libc imports, so new platform ports error out early Result NIO builds natively on Android again, with all the same tests passing
…bc not found (#2451) Motivation Fix build errors on Android Modifications - Fix previous Musl modifications that assumed Glibc wasn't imported on Android - Add errors for all libc imports, so new platform ports error out early Result NIO builds natively on Android again, with all the same tests passing
Since Musl is sufficiently different from Glibc (see https://wiki.musl-libc.org/functional-differences-from-glibc.html), it requires a different import, which now should be applied to files that have
import Glibcin them.